media/base/media_stub.cc - Issue 10919092: Build supported media targets on iOS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/media_stub.cc

Issue 10919092: Build supported media targets on iOS. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Add use_ffmpeg flag. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "media/base/media.h"	5 #include "media/base/media.h"

6 #include "base/logging.h"	6 #include "base/logging.h"
	stuartmorgan 2012/09/05 12:34:24 Blank line above this one (the Android file was wr Blank line above this one (the Android file was wrong) blundell 2012/09/05 12:51:08 Done. Show quoted text On 2012/09/05 12:34:24, stuartmorgan wrote: > Blank line above this one (the Android file was wrong) Done.
7	7
	stuartmorgan 2012/09/05 12:34:24 Put a short comment here explaining the file, like Put a short comment here explaining the file, like: // This file is intended for platforms that don't need to load any media libraries // (e.g., Android and iOS). blundell 2012/09/05 12:51:08 Done. Show quoted text On 2012/09/05 12:34:24, stuartmorgan wrote: > Put a short comment here explaining the file, like: > > // This file is intended for platforms that don't need to load any media > libraries > // (e.g., Android and iOS). Done.
8 namespace media {	8 namespace media {

9	9

10 bool InitializeMediaLibrary(const FilePath& module_dir) {	10 bool InitializeMediaLibrary(const FilePath& module_dir) {

11 // Android doesn't require any additional media libraries.

12 return true;	11 return true;

13 }	12 }

14	13

15 void InitializeMediaLibraryForTesting() {}	14 void InitializeMediaLibraryForTesting() {}
	stuartmorgan 2012/09/05 12:34:24 I think this is more readable with a break before I think this is more readable with a break before }, but we don't have a rule AFAIK so you can leave it if you want. blundell 2012/09/05 12:51:08 Done. Show quoted text On 2012/09/05 12:34:24, stuartmorgan wrote: > I think this is more readable with a break before }, but we don't have a rule > AFAIK so you can leave it if you want. Done.
16	15

17 bool IsMediaLibraryInitialized() {	16 bool IsMediaLibraryInitialized() {

18 return true;	17 return true;

19 }	18 }

20	19

21 } // namespace media	20 } // namespace media

OLD	NEW

« no previous file with comments | « media/base/media_android.cc ('k') | media/media.gyp » ('j') | media/media.gyp » ('J')