Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issue 10919076: app_list: Paint background for app item title. (Closed)

Created:
8 years, 3 months ago by xiyuan
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, benwells
Visibility:
Public.

Description

app_list: Paint background for app item title. So that they are not drawn on transparency and have artifacts. BUG=146221 TEST=Verify no artifacts around app item title. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154869

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M ui/app_list/app_list.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/app_list_bubble_border.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A + ui/app_list/app_list_constants.h View 1 chunk +5 lines, -6 lines 0 comments Download
A + ui/app_list/app_list_constants.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M ui/app_list/app_list_item_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/app_list/search_result_view.cc View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
As a side effect of turning on layers on AppListItemView, the title is painted on ...
8 years, 3 months ago (2012-09-04 18:27:38 UTC) #1
sky
LGTM http://codereview.chromium.org/10919076/diff/1/ui/app_list/app_list.gyp File ui/app_list/app_list.gyp (right): http://codereview.chromium.org/10919076/diff/1/ui/app_list/app_list.gyp#newcode25 ui/app_list/app_list.gyp:25: 'app_list_constants.cc', sort
8 years, 3 months ago (2012-09-04 20:11:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10919076/6001
8 years, 3 months ago (2012-09-04 20:17:55 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-05 00:45:55 UTC) #4
Change committed as 154869

Powered by Google App Engine
This is Rietveld 408576698