Move android mediaplayer from render process to browser process.

content/browser/android/cookie_getter_impl.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/android/cookie_getter_impl.h"
+
+#include "base/bind.h"
+#include "content/public/browser/browser_thread.h"
+#include "googleurl/src/gurl.h"
+#include "net/cookies/cookie_store.h"
+#include "net/url_request/url_request_context.h"
+#include "net/url_request/url_request_context_getter.h"
+
+using content::BrowserThread;
+
+namespace content {
+
+CookieGetterImpl::CookieGetterImpl(
+    net::URLRequestContextGetter* context_getter)
+    : context_getter_(context_getter),
+      ALLOW_THIS_IN_INITIALIZER_LIST(weak_this_(this)) {
+}
+
+CookieGetterImpl::~CookieGetterImpl() {}
+
+void CookieGetterImpl::GetCookies(
+    const std::string& url, const GetCookieCB& callback) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  BrowserThread::PostTask(
+      BrowserThread::IO,
+      FROM_HERE,
+      base::Bind(&CookieGetterImpl::RequestCookies,
+                 weak_this_.GetWeakPtr(), url, callback));
+}
+
+void CookieGetterImpl::RequestCookies(
+    const std::string& url, const GetCookieCB& callback) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  net::CookieOptions options;
+  options.set_include_httponly();
+  net::CookieStore* cookie_store =
+      context_getter_->GetURLRequestContext()->cookie_store();

[nilesh, 2012/09/11 05:48:48]

I think you are supposed to ask the request context' network delegate whether
you can get cookies
(http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/net/chrome_...)
 

Please see
http://code.google.com/searchframe#OAMlx_jo-ck/src/content/browser/android/do...
for similar code to get cookies for a URL. A lot of code is duplicated and it
would be great if we can have a cookie getter helper class  to share the
functionality and make this class independent (not an implementation of
media::CookieGetter). 

[qinmin, 2012/09/12 23:12:52]

This is getting a little more complicated. Added a new class CookieGetterTask to
check the policy and getting the cookie on the io thread.
This implementation is a little different from the DownloadManager because we
don't have the UrlRequest object.
However, the code shares a lot of functionalities with render_message_filter.
I will refactor the code later to make CookieGetterTask shared. Currently the
change is already big enough. Don't want to put more burden on the review
process.


On 2012/09/11 05:48:48, nileshagrawal1 wrote:

+  base::Callback<void(const std::string&)> cb = base::Bind(
+      &CookieGetterImpl::ReturnCookies, weak_this_.GetWeakPtr(), callback);
+  if (cookie_store) {
+    cookie_store->GetCookiesWithOptionsAsync(
+        GURL(url), options, cb);
+  } else {
+    std::string cookies;
+    ReturnCookies(callback, cookies);
+  }
+}
+
+void CookieGetterImpl::ReturnCookies(
+    const GetCookieCB& callback, const std::string& cookies) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  BrowserThread::PostTask(
+      BrowserThread::UI,
+      FROM_HERE,
+      base::Bind(&CookieGetterImpl::GetCookiesCallback,
+                 weak_this_.GetWeakPtr(), cookies, callback));
+}
+
+void CookieGetterImpl::GetCookiesCallback(
+    const std::string& cookies, const GetCookieCB& callback) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  callback.Run(cookies);
+}
+
+}  // namespace content