Move android mediaplayer from render process to browser process.

content/browser/android/cookies_retriever_impl.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/android/cookies_retriever_impl.h"
+
+#include "base/bind.h"
+#include "content/public/browser/browser_thread.h"
+#include "googleurl/src/gurl.h"
+#include "net/cookies/cookie_store.h"
+#include "net/url_request/url_request_context.h"
+#include "net/url_request/url_request_context_getter.h"
+
+using content::BrowserThread;
+
+namespace content {
+
+CookiesRetrieverImpl::CookiesRetrieverImpl(
+    net::URLRequestContextGetter* context_getter)
+    : context_getter_(context_getter) {
+}
+
+CookiesRetrieverImpl::~CookiesRetrieverImpl() {
+}
+
+void CookiesRetrieverImpl::GetCookiesAsync(std::string url,
+    const media::CookiesRetriever::GetCookieCB& callback) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  url_ = url;
+  get_cookies_cb_ = callback;
+  BrowserThread::PostTask(
+      BrowserThread::IO,
+      FROM_HERE,
+      base::Bind(&CookiesRetrieverImpl::RequestCookies,
+                 this));
+}
+
+void CookiesRetrieverImpl::RequestCookies() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  net::CookieOptions options;
+  options.set_include_httponly();
+  net::CookieStore* cookie_store =
+      context_getter_->GetURLRequestContext()->cookie_store();
+  if (cookie_store) {
+    cookie_store->GetCookiesWithOptionsAsync(
+        GURL(url_), options, base::Bind(&CookiesRetrieverImpl::ReturnCookies,
+            this));
+  } else {
+    std::string cookies;
+    ReturnCookies(cookies);
+  }
+}
+
+void CookiesRetrieverImpl::ReturnCookies(const std::string& cookies) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  cookies_ = cookies;

[Yaron, 2012/09/05 07:03:56]

Hrmm. Could you you have multiple calls to ReturnCookies such that one races
with the previous instance and both are accessing |cookies_|? Could you not pass
cookies through the callback instead?

[qinmin, 2012/09/05 19:34:42]

That should not happen in the current code logic. But I have changed the code to
pass cookies through callback.

On 2012/09/05 07:03:56, Yaron wrote:

+  BrowserThread::PostTask(
+      BrowserThread::UI,
+      FROM_HERE,
+      base::Bind(&CookiesRetrieverImpl::GetCookiesCallback, this));
+}
+
+void CookiesRetrieverImpl::GetCookiesCallback() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  get_cookies_cb_.Run(cookies_);
+}
+
+}  // namespace content