Move android mediaplayer from render process to browser process.

content/renderer/render_view_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 85 matching lines @@
 class WebUIBindings;
 
 namespace content {
 class DocumentState;
 class NavigationState;
 class P2PSocketDispatcher;
 class RenderViewObserver;
 class RenderViewTest;
 class RendererAccessibility;
 class RendererPpapiHost;
+#if defined(OS_ANDROID)
+class WebMediaPlayerProxyImplAndroid;
+#endif
 struct CustomContextMenuContext;
 struct FileChooserParams;
 
 namespace old {
 class GuestToEmbedderChannel;
 }
 
 }  // namespace content
 
 namespace gfx {
@@ skipping 14 matching lines @@
 
 }  // namespace webkit
 
 namespace webkit_glue {
 class ImageResourceFetcher;
 class ResourceFetcher;
 }
 
 #if defined(OS_ANDROID)
 namespace webkit_media {
+class MediaPlayerBridgeManagerImpl;
 class WebMediaPlayerManagerAndroid;
 }
 #endif
 
 namespace WebKit {
 class WebApplicationCacheHost;
 class WebApplicationCacheHostClient;
 class WebCompositorOutputSurface;
 class WebDOMMessageEvent;
 class WebDataSource;
@@ skipping 1245 matching lines @@
   // Android Specific ---------------------------------------------------------
 
   // Expected id of the next content intent launched. Used to prevent scheduled
   // intents to be launched if aborted.
   size_t expected_content_intent_id_;
 
   // List of click-based content detectors.
   typedef std::vector< linked_ptr<content::ContentDetector> >
       ContentDetectorList;
   ContentDetectorList content_detectors_;
+
+  // Proxy class for WebMediaPlayer to communicate with the real mediaplayer
+  // objects in browser process. This object is lazily initialized.
+  content::WebMediaPlayerProxyImplAndroid* media_player_proxy_;

[scherkus (not reviewing), 2012/09/07 13:17:35]

who owns this object? are we leaking it?

[qinmin, 2012/09/07 22:48:27]

This object is inherited from RenderViewObserver. In
RenderViewImpl::~RenderViewImpl(), all the dtors of RenderViewObserver will get
called. Added a comment here to mention this.
So we are fine here.

On 2012/09/07 13:17:35, scherkus wrote:

+
+  // The media player manager for managing all the media players on this view.
+  scoped_ptr<webkit_media::WebMediaPlayerManagerAndroid> media_player_manager_;
+
+  // Resource manager for all the android mediaplayer objects if they are
+  // created in the renderer process. This object is lazily initialized.
+  scoped_ptr<webkit_media::MediaPlayerBridgeManagerImpl> media_bridge_manager_;
 #endif
 
   // Misc ----------------------------------------------------------------------
 
   // The current and pending file chooser completion objects. If the queue is
   // nonempty, the first item represents the currently running file chooser
   // callback, and the remaining elements are the other file chooser completion
   // still waiting to be run (in order).
   struct PendingFileChooser;
   std::deque< linked_ptr<PendingFileChooser> > file_chooser_completions_;
@@ skipping 38 matching lines @@
   // is fine.
   ObserverList<content::RenderViewObserver> observers_;
 
   // Used to inform didChangeSelection() when it is called in the context
   // of handling a ViewMsg_SelectRange IPC.
   bool handling_select_range_;
 
   // Wraps the |webwidget_| as a MouseLockDispatcher::LockTarget interface.
   scoped_ptr<MouseLockDispatcher::LockTarget> webwidget_mouse_lock_target_;
 
-#if defined(OS_ANDROID)
-  // The media player manager for managing all the media players on this view.
-  scoped_ptr<webkit_media::WebMediaPlayerManagerAndroid> media_player_manager_;
-#endif
-
   // Plugins -------------------------------------------------------------------
 
   // All the currently active plugin delegates for this RenderView; kept so
   // that we can enumerate them to send updates about things like window
   // location or tab focus and visibily. These are non-owning references.
   std::set<WebPluginDelegateProxy*> plugin_delegates_;
 
 #if defined(OS_WIN)
   // The ID of the focused NPAPI plug-in.
   int focused_plugin_id_;
@@ skipping 59 matching lines @@
   // bunch of stuff, you should probably create a helper class and put your
   // data and methods on that to avoid bloating RenderView more.  You can
   // use the Observer interface to filter IPC messages and receive frame change
   // notifications.
   // ---------------------------------------------------------------------------
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
 };
 
 #endif  // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_