Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 10919049: Fix for clang chromium-style in promo. (Closed)

Created:
8 years, 3 months ago by aruslan
Modified:
8 years, 3 months ago
Reviewers:
achuithb
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix for clang chromium-style in promo. ./chrome/browser/web_resource/notification_promo_mobile_ntp.h:21:1: error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor. class NotificationPromoMobileNtp { BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/web_resource/notification_promo_mobile_ntp.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/web_resource/notification_promo_mobile_ntp.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aruslan
Please take a look, thanks!
8 years, 3 months ago (2012-08-31 23:38:52 UTC) #1
achuithb
lgtm
8 years, 3 months ago (2012-08-31 23:55:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/10919049/1
8 years, 3 months ago (2012-08-31 23:58:06 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-01 02:25:00 UTC) #4
Change committed as 154576

Powered by Google App Engine
This is Rietveld 408576698