chrome/common/extensions/api/windows.json - Issue 10919046: Allow panels to be created as detached panels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/windows.json

Issue 10919046: Allow panels to be created as detached panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: avoid panel_create_mode being unused_var in Ash Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/panels/panel_view.cc ('k') | chrome/test/data/extensions/api_test/window_open/panel_detached/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/windows.json

diff --git a/chrome/common/extensions/api/windows.json b/chrome/common/extensions/api/windows.json

index 9e3cd85e221e48817c47380654e88bc846dd815e..dbfe080f7648f9274e1a7679aed469d0500867a4 100644

--- a/chrome/common/extensions/api/windows.json

+++ b/chrome/common/extensions/api/windows.json

@@ -173,8 +173,8 @@

"type": {

"type": "string",

"optional": true,

- "description": "Specifies what type of browser window to create. The 'panel' type creates a popup unless the '--enable-panels' flag is set.",

- "enum": ["normal", "popup", "panel"]

+ "description": "Specifies what type of browser window to create. The 'panel' and 'detached_panel' types create a popup unless the '--enable-panels' flag is set.",

+ "enum": ["normal", "popup", "panel", "detached_panel"]

}

"optional": true