chrome/browser/ui/panels/panel_cocoa_unittest.mm - Issue 10919046: Allow panels to be created as detached panels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_cocoa_unittest.mm

Issue 10919046: Allow panels to be created as detached panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: avoid panel_create_mode being unused_var in Ash Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_cocoa_unittest.mm

diff --git a/chrome/browser/ui/panels/panel_cocoa_unittest.mm b/chrome/browser/ui/panels/panel_cocoa_unittest.mm

index 89b4f5fb4c73250c043a206b5f20e5fc2f33de4b..700d369ed6ba0571398d1207ccdabb086c8619d0 100644

--- a/chrome/browser/ui/panels/panel_cocoa_unittest.mm

+++ b/chrome/browser/ui/panels/panel_cocoa_unittest.mm

@@ -52,7 +52,8 @@ class PanelCocoaTest : public CocoaProfileTest {

int panels_count = manager->num_panels();

Panel* panel = manager->CreatePanel(panel_name, profile(),

- GURL(), gfx::Size());

+ GURL(), gfx::Rect(),

+ PanelManager::CREATE_AS_DOCKED);

EXPECT_EQ(panels_count + 1, manager->num_panels());

EXPECT_TRUE(panel);