chrome/browser/task_manager/task_manager_browsertest.cc - Issue 10919046: Allow panels to be created as detached panels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_browsertest.cc

Issue 10919046: Allow panels to be created as detached panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: avoid panel_create_mode being unused_var in Ash Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/task_manager/task_manager_browsertest.cc

diff --git a/chrome/browser/task_manager/task_manager_browsertest.cc b/chrome/browser/task_manager/task_manager_browsertest.cc

index 483ca659e35896bcacdc5acbd2bbd42ee1857588..6ecf4c96ce4e8e3aa1e2636c077795dde2e62d60 100644

--- a/chrome/browser/task_manager/task_manager_browsertest.cc

+++ b/chrome/browser/task_manager/task_manager_browsertest.cc

@@ -151,7 +151,8 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, MAYBE_NoticePanelChanges) {

last_loaded_extension_id_),

browser()->profile(),

url,

- gfx::Size(300, 400));

+ gfx::Rect(300, 400),

+ PanelManager::CREATE_AS_DOCKED);

TaskManagerBrowserTestUtil::WaitForResourceChange(4);

// Check that the fourth entry is a resource with the panel's web contents