Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 10919042: DISABLE BrowserTest.PageZoom on Windows - flaky on XP starting circa r154109. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 807acdafdf10147d6bde9ef083878ef140b01a62..aa544af47bb9e6afd3e6b97c22d173ad4df8b3fb 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -1226,7 +1226,14 @@ IN_PROC_BROWSER_TEST_F(BrowserTest,
EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_IMPORT_SETTINGS));
}
-IN_PROC_BROWSER_TEST_F(BrowserTest, PageZoom) {
+#if defined(OS_WIN)
+// Flakes regularly on Windows XP
+// http://crbug.com/146040
+#define MAYBE_PageZoom DISABLED_PageZoom
+#else
+#define MAYBE_PageZoom PageZoom
+#endif
+IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_PageZoom) {
WebContents* contents = chrome::GetActiveWebContents(browser());
bool enable_plus, enable_minus;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698