Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 10919028: Disable memory allocation code from being instrumented by cygprofiler. (Closed)

Created:
8 years, 3 months ago by glotov
Modified:
8 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Disable memory allocation code from being instrumented by cygprofiler. Before this change I had to use linux_use_tcmalloc=0, but it stopped working recently. BUG=none TEST=build chromeos-chrome using steps in [1] and make sure it saves log to /var/log/chrome/cygprofile.* [1] https://sites.google.com/a/google.com/chrome-msk/dev/boot-speed-up-effort/order-file-development-guide Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M base/allocator/allocator.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
glotov
Hi! Please have a look.
8 years, 3 months ago (2012-08-31 15:48:41 UTC) #1
Dmitry Polukhin
LGTM
8 years, 3 months ago (2012-09-03 07:43:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/10919028/1
8 years, 3 months ago (2012-09-03 09:45:35 UTC) #3
commit-bot: I haz the power
Presubmit check for 10919028-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-03 09:45:38 UTC) #4
glotov
Darin, could you put an owner lgtm, please.
8 years, 3 months ago (2012-09-03 10:05:27 UTC) #5
glotov
just a friendly ping
8 years, 3 months ago (2012-09-05 10:16:49 UTC) #6
darin (slow to review)
LGTM
8 years, 3 months ago (2012-09-05 17:52:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/10919028/1
8 years, 3 months ago (2012-09-06 07:22:27 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 09:43:21 UTC) #9
Change committed as 155157

Powered by Google App Engine
This is Rietveld 408576698