Add async trace events to trace progress of IPC messages

chrome/nacl/nacl_ipc_adapter_unittest.cc

Index: chrome/nacl/nacl_ipc_adapter_unittest.cc
diff --git a/chrome/nacl/nacl_ipc_adapter_unittest.cc b/chrome/nacl/nacl_ipc_adapter_unittest.cc
index 7f3c55a92f5c223c52f64a53d708a84ac520fcdf..ec5bd04e3739463ef80e9a18ab3b978f7b37c906 100644
--- a/chrome/nacl/nacl_ipc_adapter_unittest.cc
+++ b/chrome/nacl/nacl_ipc_adapter_unittest.cc
@@ -92,8 +92,16 @@ TEST_F(NaClIPCAdapterTest, SimpleReceiveRewriting) {
   EXPECT_EQ(sizeof(int), output_header->payload_size);
   EXPECT_EQ(routing_id, output_header->routing);
   EXPECT_EQ(type, output_header->type);
+  uint32 flags_mask =
+      IPC::Message::PRIORITY_MASK |

[Mark Seaborn, 2012/09/04 18:39:31]

If someone adds a flag (maybe after removing a flag or changing the
apportionment between the flags and reference number), they're likely not to
know to add it here, so the test would become weaker.

Maybe add an ALL_FLAGS_MASK to ipc_message.h or add a getter function that
extracts the flags?

[jbates, 2012/09/04 20:02:18]

It looks like this test just needs to verify that flags goes through unchanged,
right? I changed the test to get the flags member after constructing the
Message, and then check it afterwards. PTAL.

+      IPC::Message::SYNC_BIT |
+      IPC::Message::REPLY_BIT |
+      IPC::Message::REPLY_ERROR_BIT |
+      IPC::Message::UNBLOCK_BIT |
+      IPC::Message::PUMPING_MSGS_BIT |
+      IPC::Message::HAS_SENT_TIME_BIT;
   EXPECT_EQ(static_cast<uint32>(IPC::Message::PRIORITY_NORMAL),
-            output_header->flags);
+            static_cast<uint32>(output_header->flags & flags_mask));
   EXPECT_EQ(0u, output_header->num_fds);
   EXPECT_EQ(0u, output_header->pad);