[Android] Port simple ContentSettings tests to android_webview.

[Android] Port simple ContentSettings tests to android_webview.

This CL depends on https://chromiumcodereview.appspot.com/10908014/

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154435

[joth, 2012-08-30 20:14:59]

lgtm.

(who gets the upstreaming points? The nascent AwTeam ?)

https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
(right):

https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:327:
// has got, so we are to return an empty string here.
"The test expects the getter returns exactly the same as the setter set, ... " ?

Also, that comment makes it sound like the test is asserting the wrong thing. I
see it maybe easiest to compensate for it here, but still may mislead someone
reading the test in isolation into thinking the function behaves otherwise to
what it actually does?

https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:341:
getTitleOnUiThread());
nit: wrong indent for java,

https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:416:
false);
again this is c++ style indent.

[mnaganov (inactive), 2012-08-31 12:43:21]

https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
(right):

https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:327:
// has got, so we are to return an empty string here.
On 2012/08/30 20:14:59, joth wrote:
> "The test expects the getter returns exactly the same as the setter set, ... "
?
> 
> Also, that comment makes it sound like the test is asserting the wrong thing.
I
> see it maybe easiest to compensate for it here, but still may mislead someone
> reading the test in isolation into thinking the function behaves otherwise to
> what it actually does?

Rephrased the comment:

// The test framework expects that getXXX() == Z after setXXX(Z).     
// But setUserAgentString("" / null) resets the UA string to default, 
// and getUserAgentString returns the default UA string afterwards.   
// To align with the framework, we return an empty string instead of  
// the default UA.

https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:341:
getTitleOnUiThread());
On 2012/08/30 20:14:59, joth wrote:
> nit: wrong indent for java,

Done.

https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:416:
false);
On 2012/08/30 20:14:59, joth wrote:
> again this is c++ style indent. 

Fixed here an in other places.

[Yaron, 2012-08-31 18:17:00]

On 2012/08/31 12:43:21, Mikhail Naganov (Chromium) wrote:
>
https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
> File
>
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
>
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:327:
> // has got, so we are to return an empty string here.
> On 2012/08/30 20:14:59, joth wrote:
> > "The test expects the getter returns exactly the same as the setter set, ...
"
> ?
> > 
> > Also, that comment makes it sound like the test is asserting the wrong
thing.
> I
> > see it maybe easiest to compensate for it here, but still may mislead
someone
> > reading the test in isolation into thinking the function behaves otherwise
to
> > what it actually does?
> 
> Rephrased the comment:
> 
> // The test framework expects that getXXX() == Z after setXXX(Z).     
> // But setUserAgentString("" / null) resets the UA string to default, 
> // and getUserAgentString returns the default UA string afterwards.   
> // To align with the framework, we return an empty string instead of  
> // the default UA.
> 
>
https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
>
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:341:
> getTitleOnUiThread());
> On 2012/08/30 20:14:59, joth wrote:
> > nit: wrong indent for java,
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
>
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:416:
> false);
> On 2012/08/30 20:14:59, joth wrote:
> > again this is c++ style indent. 
> 
> Fixed here an in other places.

I assume when brought down, you'll remove these tests from ContentSetingsTest?

[mnaganov (inactive), 2012-09-01 20:35:23]

On 2012/08/31 18:17:00, Yaron wrote:
> On 2012/08/31 12:43:21, Mikhail Naganov (Chromium) wrote:
> >
>
https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
> > File
> >
>
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
> > (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
> >
>
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:327:
> > // has got, so we are to return an empty string here.
> > On 2012/08/30 20:14:59, joth wrote:
> > > "The test expects the getter returns exactly the same as the setter set,
...
> "
> > ?
> > > 
> > > Also, that comment makes it sound like the test is asserting the wrong
> thing.
> > I
> > > see it maybe easiest to compensate for it here, but still may mislead
> someone
> > > reading the test in isolation into thinking the function behaves otherwise
> to
> > > what it actually does?
> > 
> > Rephrased the comment:
> > 
> > // The test framework expects that getXXX() == Z after setXXX(Z).     
> > // But setUserAgentString("" / null) resets the UA string to default, 
> > // and getUserAgentString returns the default UA string afterwards.   
> > // To align with the framework, we return an empty string instead of  
> > // the default UA.
> > 
> >
>
https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
> >
>
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:341:
> > getTitleOnUiThread());
> > On 2012/08/30 20:14:59, joth wrote:
> > > nit: wrong indent for java,
> > 
> > Done.
> > 
> >
>
https://chromiumcodereview.appspot.com/10919010/diff/1/android_webview/javate...
> >
>
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:416:
> > false);
> > On 2012/08/30 20:14:59, joth wrote:
> > > again this is c++ style indent. 
> > 
> > Fixed here an in other places.
> 
> I assume when brought down, you'll remove these tests from ContentSetingsTest?

Only when we'll get android_webview tests running on a bot.

[mkosiba (inactive), 2012-09-04 21:49:00]

Congratulations@! You broke the build:

    [javac]
/usr/local/google/code/chromium/src/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:12:
cannot find symbol
    [javac] symbol  : class UrlUtils
    [javac] location: package org.chromium.base.test
    [javac] import org.chromium.base.test.UrlUtils;
    [javac]                              ^
    [javac]
/usr/local/google/code/chromium/src/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:391:
cannot find symbol
    [javac] symbol  : variable UrlUtils
    [javac] location: class
org.chromium.android_webview.test.AwSettingsTest.AwSettingsDomStorageEnabledTestHelper
    [javac]                
UrlUtils.getTestFileUrl("webview/localStorage.html"));
    [javac]                 ^
    [javac] Note:
/usr/local/google/code/chromium/src/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
uses or overrides a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 2 errors