Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: runtime/vm/compiler.cc

Issue 10919008: Unbox phis that were proven to be of type Double. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address Srdjan's comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/deopt_instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index f331f69ff80fe449eb957028b77445a263f69668..64f05064be8ea17b4c140b7c5e0ce68a3dff2897 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -179,10 +179,6 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
}
if (optimized) {
- // TODO(vegorov): we need to compute uses for the
- // purposes of unboxing. Move unboxing to a later
- // stage.
- // Compute the use lists.
flow_graph->ComputeUseLists();
FlowGraphOptimizer optimizer(flow_graph);
@@ -209,7 +205,12 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
// Do optimizations that depend on the propagated type information.
optimizer.OptimizeComputations();
+ // Unbox doubles.
+ flow_graph->ComputeUseLists();
+ optimizer.SelectRepresentations();
+
if (FLAG_cse) {
+ flow_graph->ComputeUseLists();
DominatorBasedCSE::Optimize(flow_graph->graph_entry());
}
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/deopt_instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698