Unbox phis that were proven to be of type Double.

runtime/vm/assembler_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/heap.h"
 #include "vm/memory_region.h"
@@ skipping 1675 matching lines @@
 }
 
 
 // TODO(srdjan): Add XMM registers once they are used by the compiler.
 // Based on http://x86-64.org/documentation/abi.pdf Fig. 3.4
 static const intptr_t kNumberOfVolatileCpuRegisters = 9;
 static const Register volatile_cpu_registers[kNumberOfVolatileCpuRegisters] = {
     RAX, RCX, RDX, RSI, RDI, R8, R9, R10, R11
 };
 
+static const intptr_t kNumberOfVolatileRegisters =
+    kNumberOfVolatileCpuRegisters + (kNumberOfXmmRegisters - 1);

[srdjan, 2012/08/30 17:59:24]

ditto

[Vyacheslav Egorov (Google), 2012/09/21 12:51:52]

Done.

+
 
 void Assembler::EnterCallRuntimeFrame(intptr_t frame_space) {
   enter(Immediate(0));
 
-  // Preserve volatile registers.
+  // Preserve volatile CPU registers.
   for (intptr_t i = 0; i < kNumberOfVolatileCpuRegisters; i++) {
     pushq(volatile_cpu_registers[i]);
   }
 
+  // Preserve all XMM registers except XMM0
+  subq(RSP, Immediate((kNumberOfXmmRegisters - 1) * kDoubleSize));
+  // Store XMM registers with the lowest register number at the lowest
+  // address.
+  intptr_t offset = 0;
+  for (intptr_t reg_idx = 1; reg_idx < kNumberOfXmmRegisters; ++reg_idx) {
+    XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx);
+    movsd(Address(RSP, offset), xmm_reg);
+    offset += kDoubleSize;
+  }
+
   ReserveAlignedFrameSpace(frame_space);
 }
 
 
 void Assembler::LeaveCallRuntimeFrame() {
   // RSP might have been modified to reserve space for arguments
   // and ensure proper alignment of the stack frame.
   // We need to restore it before restoring registers.
-  leaq(RSP, Address(RBP, -kNumberOfVolatileCpuRegisters * kWordSize));
+  leaq(RSP, Address(RBP, -kNumberOfVolatileRegisters * kWordSize));
 
-  // Restore volatile registers.
+  // Restore all XMM registers except XMM0
+  // XMM registers have the lowest register number at the lowest address.
+  intptr_t offset = 0;
+  for (intptr_t reg_idx = 1; reg_idx < kNumberOfXmmRegisters; ++reg_idx) {
+    XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx);
+    movsd(xmm_reg, Address(RSP, offset));
+    offset += kDoubleSize;
+  }
+  addq(RSP, Immediate(offset));
+
+  // Restore volatile CPU registers.
   for (intptr_t i = kNumberOfVolatileCpuRegisters - 1; i >= 0; i--) {
     popq(volatile_cpu_registers[i]);
   }
 
   leave();
 }
 
 
 void Assembler::CallRuntime(const RuntimeEntry& entry) {
   entry.Call(this);
@@ skipping 213 matching lines @@
 
 const char* Assembler::XmmRegisterName(XmmRegister reg) {
   ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
   return xmm_reg_names[reg];
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64