Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10918283: Fix render_widget_host_view_android.h (Closed)

Created:
8 years, 3 months ago by Yusuf
Modified:
8 years, 3 months ago
Reviewers:
Nico, Jói
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, Tao Bai
Visibility:
Public.

Description

Fix render_widget_host_view_android.h This adds the virtual pure function to base class. The overridden version was upstreamed without the base class changes and causing a clang build error. BUG=143931 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157928

Patch Set 1 #

Patch Set 2 : Add the pure method to base class matching downstream to upstream #

Patch Set 3 : Added overridden call to test_render_view_host.h #

Patch Set 4 : Removed unnecessary #elif #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/renderer_host/test_render_view_host.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Yusuf
8 years, 3 months ago (2012-09-17 21:19:22 UTC) #1
Yusuf
joi@ friendly ping. This CL is to get Chrome for Android building with Clang. One ...
8 years, 3 months ago (2012-09-19 20:44:46 UTC) #2
Jói
LGTM
8 years, 3 months ago (2012-09-20 10:05:14 UTC) #3
Jói
Sorry for the delay, I didn't realize I was the reviewer as the initial email ...
8 years, 3 months ago (2012-09-20 10:07:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/10918283/10003
8 years, 3 months ago (2012-09-20 17:23:52 UTC) #5
commit-bot: I haz the power
Presubmit check for 10918283-10003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-20 17:23:55 UTC) #6
Yusuf
8 years, 3 months ago (2012-09-20 17:53:47 UTC) #7
Yusuf
thakis@ for content/browser/renderer_host
8 years, 3 months ago (2012-09-20 17:54:11 UTC) #8
Nico
lgtm
8 years, 3 months ago (2012-09-21 02:36:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/10918283/10003
8 years, 3 months ago (2012-09-21 02:36:54 UTC) #10
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 04:50:30 UTC) #11
Change committed as 157928

Powered by Google App Engine
This is Rietveld 408576698