Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 10918281: Enable webkit_compositor_bindings_unittests in component builds (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Enable webkit_compositor_bindings_unittests in component builds This shares the compositor setup code from cc_unittests so we can run webkit_compositor_bindings_unittests in component builds. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -68 lines) Patch
M cc/cc_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/run_all_unittests.cc View 1 chunk +2 lines, -54 lines 0 comments Download
A cc/test/test_webkit_platform.h View 1 chunk +44 lines, -0 lines 0 comments Download
A cc/test/test_webkit_platform.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M webkit/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/compositor_bindings/WebLayerTreeViewTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings_tests.gyp View 3 chunks +2 lines, -3 lines 0 comments Download
M webkit/compositor_bindings/test/run_all_unittests.cc View 1 chunk +7 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
8 years, 3 months ago (2012-09-17 20:28:14 UTC) #1
enne (OOO)
LGTM
8 years, 3 months ago (2012-09-17 21:10:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10918281/1
8 years, 3 months ago (2012-09-18 01:31:51 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) interactive_ui_tests, jingle_unittests, gpu_unittests, base_unittests, sync_integration_tests, sql_unittests, chrome_frame_unittests, content_unittests, ...
8 years, 3 months ago (2012-09-18 01:47:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10918281/1
8 years, 3 months ago (2012-09-18 18:03:59 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 20:58:28 UTC) #6
Change committed as 157416

Powered by Google App Engine
This is Rietveld 408576698