Issue 10918275: [gtk] website settings bubble

Issue 10918275: [gtk] website settings bubble (Closed)

Created:
8 years, 3 months ago by Evan Stade

Modified:
8 years, 3 months ago

Reviewers:
markusheintz_, Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[gtk] polish website settings bubble revise the tabstrip, fix up padding constants, improve the appearance of the close button, make most labels non-selectable To do this, I had to change BubbleGtk to let the contents use the entire bubble, and this triggered me to also fix some other bubbles which had the wrong amount of border. BUG=150750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157739

Patch Set 1 #

Patch Set 2 : checkpoint #

Patch Set 3 : fin #

Total comments: 3

Patch Set 4 : fix up a lot of extra bubbles #

Patch Set 5 : fix debug crash #

Patch Set 6 : slightly simpler drawing #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+288 lines, -137 lines)			Patch
M	chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/bubble/bubble_gtk.cc	View	1 2 3	3 chunks	+4 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/gtk/content_setting_bubble_gtk.cc	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc	View	1 2 3	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc	View	1 2 3	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/first_run_bubble.cc	View	1 2 3	2 chunks	+5 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/gtk/global_error_bubble.cc	View	1 2 3	3 chunks	+4 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc	View	1 2 3	3 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/gtk/password_generation_bubble_gtk.cc	View	1 2 3	3 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/gtk/website_settings/permission_selector.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.h	View	1 2 3 4	7 chunks	+32 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc	View	1 2 3 4 5	20 chunks	+219 lines, -69 lines	0 comments	Download
M	chrome/browser/ui/gtk/zoom_bubble_gtk.cc	View	1 2 3	4 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

+erg because I ended up touching a lot of other gtk bubbles.

8 years, 3 months ago (2012-09-19 12:51:01 UTC) #2

markusheintz_

Website Settings part LGTM. http://codereview.chromium.org/10918275/diff/10002/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc File chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc (right): http://codereview.chromium.org/10918275/diff/10002/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc#newcode676 chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc:676: // Draw the shadows that ...

8 years, 3 months ago (2012-09-19 16:44:44 UTC) #3

Evan Stade

http://codereview.chromium.org/10918275/diff/10002/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.h File chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.h (right): http://codereview.chromium.org/10918275/diff/10002/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.h#newcode50 chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.h:50: On 2012/09/19 16:44:44, markusheintz_ wrote: > nit: pls rm ...

8 years, 3 months ago (2012-09-20 08:55:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10918275/17001

8 years, 3 months ago (2012-09-20 08:55:07 UTC) #6

Change committed as 157739

Expand Messages | Collapse Messages