Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 10918264: When a DEPS file is modified, run gclient sync. (Closed)

Created:
8 years, 3 months ago by M-A Ruel
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

When a DEPS file is modified, run gclient sync. It runs it by specifying BASE/HEAD to stay at the current revision. This works around the lack of gclient sync when a DEPS file is applied on the Try Server when triggered from Rietveld. This was handled my the Try Server inside scripts/slave/chromium_command.py manually in the case a 'patch' is specified. TBR=rogerta@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157110

Patch Set 1 #

Patch Set 2 : Use BASE on Subversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M apply_issue.py View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
8 years, 3 months ago (2012-09-16 18:11:26 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
8 years, 3 months ago (2012-09-17 12:31:14 UTC) #2
M-A Ruel
BTW, the code was wrong, since HEAD is last revision on Subversion, BASE must be ...
8 years, 3 months ago (2012-09-17 13:17:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10918264/4001
8 years, 3 months ago (2012-09-17 13:18:28 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-17 13:21:14 UTC) #5
Change committed as 157110

Powered by Google App Engine
This is Rietveld 408576698