Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 10918263: Converted policy_prefs_ui.py pyauto test to a browser_test. (Closed)

Created:
8 years, 3 months ago by Joao da Silva
Modified:
8 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, Nirnimesh, kkania, anantha, robertshield, dyu1, dennis_jeffrey
Visibility:
Public.

Description

Converted policy_prefs_ui.py pyauto test to a browser_test. This is a reland of http://codereview.chromium.org/10905223/ after parameterizing the tests so they don't timeout on chromeos debug bots. BUG=143637 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157346

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -833 lines) Patch
M chrome/app/policy/PRESUBMIT.py View 4 chunks +16 lines, -21 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 3 chunks +0 lines, -42 lines 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 1 3 chunks +179 lines, -78 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 31 chunks +162 lines, -160 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 5 chunks +0 lines, -11 lines 0 comments Download
D chrome/test/functional/policy_prefs_ui.py View 1 chunk +0 lines, -180 lines 0 comments Download
D chrome/test/functional/policy_test_cases.py View 1 chunk +0 lines, -312 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
8 years, 3 months ago (2012-09-16 18:07:03 UTC) #1
jam
lgtm
8 years, 3 months ago (2012-09-17 19:31:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10918263/9001
8 years, 3 months ago (2012-09-18 08:32:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10918263/9001
8 years, 3 months ago (2012-09-18 13:05:27 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 14:02:16 UTC) #5
Change committed as 157346

Powered by Google App Engine
This is Rietveld 408576698