Make non-visible cards hidden for accessibility in CardSlider.

Make non-visible cards hidden for accessibility in CardSlider.


BUG=149134
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156967

[Dan Beam, 2012-09-14 02:48:38]

lgtm w/nits

http://codereview.chromium.org/10918241/diff/1/chrome/browser/resources/share...
File chrome/browser/resources/shared/js/cr/ui/card_slider.js (right):

http://codereview.chromium.org/10918241/diff/1/chrome/browser/resources/share...
chrome/browser/resources/shared/js/cr/ui/card_slider.js:192:
this.cards_[i].setAttribute('aria-hidden', true);
nit: 2 \s indent, optionally we usually use curlies around for loops as it's
pretty easy to think this is python and slap another method on there that might
still work but not as you'd expect.

http://codereview.chromium.org/10918241/diff/1/chrome/browser/resources/share...
chrome/browser/resources/shared/js/cr/ui/card_slider.js:358: // Mark the new
card as hidden for accessibility.  This will be corrected
nit: 1 \s between sentences

[aboxhall, 2012-09-14 03:50:36]

Waiting to see whether Dominic wants to weigh in.

http://codereview.chromium.org/10918241/diff/1/chrome/browser/resources/share...
File chrome/browser/resources/shared/js/cr/ui/card_slider.js (right):

http://codereview.chromium.org/10918241/diff/1/chrome/browser/resources/share...
chrome/browser/resources/shared/js/cr/ui/card_slider.js:192:
this.cards_[i].setAttribute('aria-hidden', true);
On 2012/09/14 02:48:38, Dan Beam wrote:
> nit: 2 \s indent, optionally we usually use curlies around for loops as it's
> pretty easy to think this is python and slap another method on there that
might
> still work but not as you'd expect.

Done.

http://codereview.chromium.org/10918241/diff/1/chrome/browser/resources/share...
chrome/browser/resources/shared/js/cr/ui/card_slider.js:358: // Mark the new
card as hidden for accessibility.  This will be corrected
On 2012/09/14 02:48:38, Dan Beam wrote:
> nit: 1 \s between sentences

Done.

[dmazzoni, 2012-09-14 06:16:57]

lgtm

[commit-bot: I haz the power, 2012-09-14 06:18:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/10918241/3002

[commit-bot: I haz the power, 2012-09-14 17:45:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/10918241/3002

[commit-bot: I haz the power, 2012-09-14 23:23:14]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-14 23:26:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/10918241/3002

[commit-bot: I haz the power, 2012-09-15 02:23:37]

Change committed as 156967