chrome/browser/ui/webui/chrome_web_ui_controller_factory.h - Issue 10918186: Expire favicons which were added with default favicon sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

Issue 10918186: Expire favicons which were added with default favicon sizes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

index 42affbfa05ab5c3648d32c8bd275f85c0d4d2f80..a9868ee7200714b74f55799c158d8ca418bf8eae 100644

--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

@@ -53,6 +53,9 @@ class ChromeWebUIControllerFactory : public content::WebUIControllerFactory {

// Gets the data for the favicon for a WebUI page. Returns NULL if the WebUI

// does not have a favicon.

+ // The returned favicon data must be

+ // |gfx::kFaviconSize| x |gfx::kFaviconSize| DIP. GetFaviconForURL() should

+ // be updated if this changes.

base::RefCountedMemory* GetFaviconResourceBytes(

const GURL& page_url, ui::ScaleFactor scale_factor) const;