Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/browser/favicon/favicon_handler.h

Issue 10918186: Expire favicons which were added with default favicon sizes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 // Used for history requests. 265 // Used for history requests.
266 CancelableRequestConsumer cancelable_consumer_; 266 CancelableRequestConsumer cancelable_consumer_;
267 267
268 // URL of the page we're requesting the favicon for. 268 // URL of the page we're requesting the favicon for.
269 GURL url_; 269 GURL url_;
270 270
271 // Whether we got the initial response for the favicon back from the renderer. 271 // Whether we got the initial response for the favicon back from the renderer.
272 // See "Favicon Details" in tab_contents.cc for more details. 272 // See "Favicon Details" in tab_contents.cc for more details.
273 bool got_favicon_from_history_; 273 bool got_favicon_from_history_;
274 274
275 // Whether the favicon is out of date. If true, it means history knows about 275 // Whether the favicon is out of date or the favicon data in
276 // the favicon, but we need to download the favicon because the icon has 276 // |history_results_| is known to be incomplete. If true, it means history
277 // expired. 277 // knows about the favicon, but we need to download the favicon because the
278 // See "Favicon Details" in tab_contents.cc for more details. 278 // icon has expired or the data in the database is incomplete.
279 bool favicon_expired_; 279 bool favicon_expired_or_incomplete_;
280 280
281 // Requests to the renderer to download favicons. 281 // Requests to the renderer to download favicons.
282 typedef std::map<int, DownloadRequest> DownloadRequests; 282 typedef std::map<int, DownloadRequest> DownloadRequests;
283 DownloadRequests download_requests_; 283 DownloadRequests download_requests_;
284 284
285 // The combination of the supported icon types. 285 // The combination of the supported icon types.
286 const int icon_types_; 286 const int icon_types_;
287 287
288 // The prioritized favicon candidates from the page back from the renderer. 288 // The prioritized favicon candidates from the page back from the renderer.
289 std::deque<FaviconURL> image_urls_; 289 std::deque<FaviconURL> image_urls_;
290 290
291 // The FaviconBitmapResults from history. 291 // The FaviconBitmapResults from history.
292 std::vector<history::FaviconBitmapResult> history_results_; 292 std::vector<history::FaviconBitmapResult> history_results_;
293 293
294 // The Profile associated with this handler. 294 // The Profile associated with this handler.
295 Profile* profile_; 295 Profile* profile_;
296 296
297 // This handler's delegate. 297 // This handler's delegate.
298 FaviconHandlerDelegate* delegate_; // weak 298 FaviconHandlerDelegate* delegate_; // weak
299 299
300 // Current favicon candidate. 300 // Current favicon candidate.
301 FaviconCandidate favicon_candidate_; 301 FaviconCandidate favicon_candidate_;
302 302
303 DISALLOW_COPY_AND_ASSIGN(FaviconHandler); 303 DISALLOW_COPY_AND_ASSIGN(FaviconHandler);
304 }; 304 };
305 305
306 #endif // CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_ 306 #endif // CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/favicon/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698