webkit/plugins/npapi/plugin_list_mac.mm - Issue 10918174: Remove PluginGroup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/npapi/plugin_list_mac.mm

Issue 10918174: Remove PluginGroup (Closed) Base URL: http://git.chromium.org/chromium/src.git@remove_async_plugin_finder

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/npapi/plugin_list_mac.mm

diff --git a/webkit/plugins/npapi/plugin_list_mac.mm b/webkit/plugins/npapi/plugin_list_mac.mm

index 74823b67221043e6d746b4432e6fc4b0e4038767..719301d0ece4be326a1a9120d390e67e7219d428 100644

--- a/webkit/plugins/npapi/plugin_list_mac.mm

+++ b/webkit/plugins/npapi/plugin_list_mac.mm

@@ -87,12 +87,6 @@ void PluginList::GetPluginsInDir(

}

-// TODO(ibraaaa): DELETE. http://crbug.com/124396

-bool PluginList::ShouldLoadPlugin(const WebPluginInfo& info,

- ScopedVector<PluginGroup>* plugin_groups) {

- return !IsBlacklistedPlugin(info);

bool PluginList::ShouldLoadPluginUsingPluginList(

const WebPluginInfo& info,

std::vector<webkit::WebPluginInfo>* plugins) {