Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: media/base/video_decoder.h

Issue 10918172: Remove VideoDecoder::PrepareForShutdownHack() and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blah Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline.cc ('k') | media/base/video_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_decoder.h
diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h
index c8fd93d35f19733e6e7dc37db013081e27139edb..b22b14438d7c7add198a778cbc0aaf1443f9454f 100644
--- a/media/base/video_decoder.h
+++ b/media/base/video_decoder.h
@@ -64,14 +64,6 @@ class MEDIA_EXPORT VideoDecoder
// that return formats with an alpha channel.
virtual bool HasAlpha() const;
- // Prepare decoder for shutdown. This is a HACK needed because
- // PipelineImpl::Stop() goes through a Pause/Flush/Stop dance to all its
- // filters, waiting for each state transition to complete before starting the
- // next, but WebMediaPlayerImpl::Destroy() holds the renderer loop hostage for
- // the duration. Default implementation does nothing; derived decoders may
- // override as needed. http://crbug.com/110228 tracks removing this.
- virtual void PrepareForShutdownHack();
-
protected:
friend class base::RefCountedThreadSafe<VideoDecoder>;
virtual ~VideoDecoder();
« no previous file with comments | « media/base/pipeline.cc ('k') | media/base/video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698