Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: media/base/pipeline.h

Issue 10918172: Remove VideoDecoder::PrepareForShutdownHack() and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blah Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/mock_filters.h ('k') | media/base/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline.h
diff --git a/media/base/pipeline.h b/media/base/pipeline.h
index e023e87224a4214539497055380e1c3fc2553c35..b90f4c4e39c0f2d31f3a36e2f4f03a7475b2bbb3 100644
--- a/media/base/pipeline.h
+++ b/media/base/pipeline.h
@@ -452,16 +452,9 @@ class MEDIA_EXPORT Pipeline
PipelineStatusCB error_cb_;
BufferingStateCB buffering_state_cb_;
- // Audio renderer reference used for setting the volume and determining
- // when playback has finished.
+ // Renderer references used for setting the volume, playback rate, and
+ // determining when playback has finished.
scoped_refptr<AudioRenderer> audio_renderer_;
-
- // Video Renderer reference used for determining when playback has finished
- // and for signalling imminent shutdown.
- // The signalling imminent shutdown is a HACK necessary because
- // WebMediaPlayerImpl::Destroy() holds the render thread loop hostage
- // until PipelineImpl::Stop() calls its callback.
- // http://crbug.com/110228 tracks removing this hack.
scoped_refptr<VideoRenderer> video_renderer_;
// Demuxer reference used for setting the preload value.
« no previous file with comments | « media/base/mock_filters.h ('k') | media/base/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698