Issue 10918161: Use WebCompositorSupport for ui/compositor initialization and shutdown

Issue 10918161: Use WebCompositorSupport for ui/compositor initialization and shutdown (Closed)

Created:
8 years, 3 months ago by jamesr

Modified:
8 years, 3 months ago

Reviewers:
Nico, piman

CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use WebCompositorSupport for ui/compositor initialization and shutdown BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155961

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	ui/compositor/compositor.cc	View		2 chunks	+6 lines, -5 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10918161/1

8 years, 3 months ago (2012-09-11 03:45:03 UTC) #3

piman

Misclick on the CQ - I unchecked, feel free to resubmit. Antoine On Mon, Sep ...

8 years, 3 months ago (2012-09-11 03:45:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10918161/1

8 years, 3 months ago (2012-09-11 04:13:44 UTC) #5

Nico

8 years, 3 months ago (2012-09-11 06:36:04 UTC) #7

https://chromiumcodereview.appspot.com/10918161/diff/1/ui/compositor/composit...
File ui/compositor/compositor.cc (right):

https://chromiumcodereview.appspot.com/10918161/diff/1/ui/compositor/composit...
ui/compositor/compositor.cc:466: COMPOSITOR_EXPORT void DisableTestCompositor()
{
drive-by nit: we don't usually have _EXPORT macros at the cc file defintions;
usually it's only in the .h files.

Expand Messages | Collapse Messages