chrome/test/nacl/nacl_browsertest.cc - Issue 10918152: Port nacl_integration exit_status test to browser_tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/nacl/nacl_browsertest.cc

Issue 10918152: Port nacl_integration exit_status test to browser_tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/test/nacl/nacl_browsertest_util.h"	5 #include "chrome/test/nacl/nacl_browsertest_util.h"

6	6

7 namespace {	7 namespace {

8	8

9 NACL_BROWSER_TEST_F(NaClBrowserTest, SimpleLoad, {	9 NACL_BROWSER_TEST_F(NaClBrowserTest, SimpleLoad, {

10 RunLoadTest(FILE_PATH_LITERAL("nacl_load_test.html"));	10 RunLoadTest(FILE_PATH_LITERAL("nacl_load_test.html"));

11 })	11 })

12	12

	13 NACL_BROWSER_TEST_F(NaClBrowserTest, ExitStatus, {

	14 RunNaClIntegrationTest(FILE_PATH_LITERAL(
	Mark Seaborn 2012/09/11 22:10:06 Indenting by 4 isn't consistent with the block abo Indenting by 4 isn't consistent with the block above Nick Bray (chromium) 2012/09/12 01:19:13 Done. Show quoted text On 2012/09/11 22:10:06, Mark Seaborn wrote: > Indenting by 4 isn't consistent with the block above Done.
	15 "pm_exit_status_test.html?trigger=exit0&expected_exit=0"

	16 ));
	Mark Seaborn 2012/09/11 22:10:06 Closing ) on a new line isn't the usual C++ style? Closing ) on a new line isn't the usual C++ style? Nick Bray (chromium) 2012/09/12 01:19:13 Done. Show quoted text On 2012/09/11 22:10:06, Mark Seaborn wrote: > Closing ) on a new line isn't the usual C++ style? Done.
	17 RunNaClIntegrationTest(FILE_PATH_LITERAL(

	18 "pm_exit_status_test.html?trigger=exit7&expected_exit=7"

	19 ));

	20 RunNaClIntegrationTest(FILE_PATH_LITERAL(

	21 "pm_exit_status_test.html?trigger=exit254&expected_exit=254"

	22 ));

	23 RunNaClIntegrationTest(FILE_PATH_LITERAL(

	24 "pm_exit_status_test.html?trigger=exitneg2&expected_exit=254"

	25 ));

	26 })

	27

13 } // namespace anonymous	28 } // namespace anonymous

OLD	NEW