Use checked in keystore to sign debug apks

Use checked in keystore to sign debug apks

keystore created with command:
keytool -genkey -v -keystore chromium-debug.keystore -alias chromiumdebugkey -keyalg RSA -keysize 2048 -validity 36525
with password "chromium" and alias password "chromium".

Android's SDK tools by default create a debug keystore in ~/.android.
This has caused all kinds of grief. Instead, this change makes us use
the new chrome-debug.keystore.

BUG=145860
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155927

[cjhopman, 2012-09-10 17:46:54]

nileshagrawal: build/android/, testing/android/
yfriedman: content/shell/android/
joth: android_webview/

[joth, 2012-09-10 17:58:25]

lgtm for android_webview

The new chrome-debug.keystore file is empty. Is that intentional?

[nilesh, 2012-09-10 18:05:04]

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets.xml
File build/android/ant/sdk-targets.xml (right):

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets....
build/android/ant/sdk-targets.xml:111: <property name="key.store"
value="${CHROMIUM_SRC}/build/android/ant/chrome-debug.keystore"/>
Please rename the key file to: chromium-apk-debug.keystore

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets....
build/android/ant/sdk-targets.xml:123: <target name="-do-debug"
depends="-set-debug-mode, -debug-obfuscation-check, -package, -post-package">
This does not fit in 100 chars.
Please add a line break before "depends"

[Isaac (away), 2012-09-10 18:17:23]

lgtm

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets.xml
File build/android/ant/sdk-targets.xml (right):

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets....
build/android/ant/sdk-targets.xml:116: <!-- SDK tools assume that
out.packaged.file is signed and name it "...-unaligned" -->
line length

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets....
build/android/ant/sdk-targets.xml:122: <!-- By default, the SDK tools build only
aligns the APK in the -do-debug target. -->
line length

[cjhopman, 2012-09-10 18:21:41]

I believe(/hope) that the keystore appears empty because it is a binary file.
This is also causing the failure on the try bot.

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets.xml
File build/android/ant/sdk-targets.xml (right):

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets....
build/android/ant/sdk-targets.xml:111: <property name="key.store"
value="${CHROMIUM_SRC}/build/android/ant/chrome-debug.keystore"/>
On 2012/09/10 18:05:04, nileshagrawal1 wrote:
> Please rename the key file to: chromium-apk-debug.keystore

Done. Also changed passwords and alias to chromium instead.

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets....
build/android/ant/sdk-targets.xml:116: <!-- SDK tools assume that
out.packaged.file is signed and name it "...-unaligned" -->
On 2012/09/10 18:17:25, Isaac wrote:
> line length
We use 100 columns for ant build files.

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets....
build/android/ant/sdk-targets.xml:123: <target name="-do-debug"
depends="-set-debug-mode, -debug-obfuscation-check, -package, -post-package">
On 2012/09/10 18:05:04, nileshagrawal1 wrote:
> This does not fit in 100 chars.
> Please add a line break before "depends"

Done.

[Isaac (away), 2012-09-10 18:36:08]

You can use the 'Try more bots' link to submit patches with a binary file (long
story).  I sent a couple for you.

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets.xml
File build/android/ant/sdk-targets.xml (right):

http://codereview.chromium.org/10918149/diff/1/build/android/ant/sdk-targets....
build/android/ant/sdk-targets.xml:111: <property name="key.store"
value="${CHROMIUM_SRC}/build/android/ant/chrome-debug.keystore"/>
Did you intend to change this for patch set 2?

[nilesh, 2012-09-10 19:31:24]

LGTM

[Yaron, 2012-09-10 19:35:12]

On 2012/09/10 19:31:24, nileshagrawal1 wrote:
> LGTM

lgtm

[commit-bot: I haz the power, 2012-09-11 00:49:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10918149/11001

[commit-bot: I haz the power, 2012-09-11 02:53:48]

Change committed as 155927