Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 10918144: Avoid allocating unnecessary result locations for some instructions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 12100)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -1055,7 +1055,9 @@
LocationSummary* locs = new LocationSummary(1, 1, LocationSummary::kNoCall);
locs->set_in(0, Location::RequiresRegister());
locs->set_temp(0, Location::RequiresRegister());
- locs->set_out(Location::SameAsFirstInput());
+ locs->set_out(is_used()
+ ? Location::SameAsFirstInput()
+ : Location::NoLocation());
return locs;
}
@@ -1063,7 +1065,7 @@
void StoreStaticFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
Register value = locs()->in(0).reg();
Register temp = locs()->temp(0).reg();
- ASSERT(locs()->out().reg() == value);
+ ASSERT(!is_used() || (locs()->out().reg() == value));
__ LoadObject(temp, field());
if (this->value()->NeedsStoreBuffer()) {
« runtime/vm/intermediate_language_ia32.cc ('K') | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698