Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 10918144: Avoid allocating unnecessary result locations for some instructions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 12100)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -1534,16 +1534,17 @@
LocationSummary* StoreVMFieldInstr::MakeLocationSummary() const {
- return LocationSummary::Make(2,
- Location::SameAsFirstInput(),
- LocationSummary::kNoCall);
+ return LocationSummary::Make(
+ 2,
+ is_used() ? Location::SameAsFirstInput() : Location::NoLocation(),
+ LocationSummary::kNoCall);
}
void StoreVMFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
Register value_reg = locs()->in(0).reg();
Register dest_reg = locs()->in(1).reg();
- ASSERT(value_reg == locs()->out().reg());
+ ASSERT(!is_used() || (value_reg == locs()->out().reg()));
if (value()->NeedsStoreBuffer()) {
__ StoreIntoObject(dest_reg, FieldAddress(dest_reg, offset_in_bytes()),
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698