Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 10918124: Android: build webview on default bots. (Closed)

Created:
8 years, 3 months ago by Torne
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android: build webview on default bots. Move the webview targets from the android_experimental target into All so they are built by default on the main tree and on trybots. The tests are not run currently; this is just checking that they compile. The libwebview target is a dependency of android_webview_apk so it doesn't need to be specified explicitly here. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/all_android.gyp View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Torne
8 years, 3 months ago (2012-09-07 17:37:33 UTC) #1
Isaac (away)
lgtm. Note this will cause the targets to be build on all our trybots as ...
8 years, 3 months ago (2012-09-07 17:52:02 UTC) #2
Isaac (away)
fyi I'm not a full committer yet, it's being processed today but CQ prob won't ...
8 years, 3 months ago (2012-09-07 17:54:23 UTC) #3
Yaron
lgtm
8 years, 3 months ago (2012-09-07 18:47:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/10918124/1
8 years, 3 months ago (2012-09-07 19:26:29 UTC) #5
commit-bot: I haz the power
Change committed as 155498
8 years, 3 months ago (2012-09-07 21:53:51 UTC) #6
Isaac (away)
8 years, 3 months ago (2012-09-09 04:03:49 UTC) #7
I forgot that new folders that we do not need for our tester need to be excluded
in bb_zip_build in buildbot/buildbot_functions.sh.  Preparing CL for that.

Powered by Google App Engine
This is Rietveld 408576698