Match paper by both PPD name and size.

printing/printing_context_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/printing_context_mac.h"
 
 #import <ApplicationServices/ApplicationServices.h>
 #import <AppKit/AppKit.h>
 
+#import <iomanip>
+#import <numeric>
+
 #include "base/logging.h"
 #include "base/mac/scoped_cftyperef.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "base/mac/scoped_nsexception_enabler.h"
 #include "base/sys_string_conversions.h"
 #include "base/values.h"
 #include "printing/print_settings_initializer_mac.h"
 
 namespace printing {
 
+namespace {
+
+// Return true if PPD name of paper is equal.
+bool IsPaperNameEqual(const PMPaper& paper1, const PMPaper& paper2) {
+  CFStringRef name1 = NULL;
+  CFStringRef name2 = NULL;
+  return (PMPaperGetPPDPaperName(paper1, &name1) == noErr) &&
+         (PMPaperGetPPDPaperName(paper2, &name2) == noErr) &&
+         (CFStringCompare(name1, name2,
+                          kCFCompareCaseInsensitive) == kCFCompareEqualTo);
+}
+
+}  // namespace
+
 // static
 PrintingContext* PrintingContext::Create(const std::string& app_locale) {
   return static_cast<PrintingContext*>(new PrintingContextMac(app_locale));
 }
 
 PrintingContextMac::PrintingContextMac(const std::string& app_locale)
     : PrintingContext(app_locale),
       print_info_([[NSPrintInfo sharedPrintInfo] copy]),
       context_(NULL) {
 }
@@ skipping 190 matching lines @@
   PMPrintSession print_session =
       static_cast<PMPrintSession>([print_info_.get() PMPrintSession]);
 
   PMPageFormat default_page_format =
       static_cast<PMPageFormat>([print_info_.get() PMPageFormat]);
 
   PMPaper default_paper;
   if (PMGetPageFormatPaper(default_page_format, &default_paper) != noErr)
     return false;
 
-  double default_page_width, default_page_height;
+  double default_page_width = 0.0;
+  double default_page_height = 0.0;
   if (PMPaperGetWidth(default_paper, &default_page_width) != noErr)
     return false;
 
   if (PMPaperGetHeight(default_paper, &default_page_height) != noErr)
     return false;
 
   PMPrinter current_printer = NULL;
   if (PMSessionGetCurrentPrinter(print_session, &current_printer) != noErr)
     return false;
 
   if (current_printer == nil)
     return false;
 
   CFArrayRef paper_list = NULL;
   if (PMPrinterGetPaperList(current_printer, &paper_list) != noErr)
     return false;
 
+  double best_match = std::numeric_limits<double>::max();
   PMPaper best_matching_paper = kPMNoData;
   int num_papers = CFArrayGetCount(paper_list);
   for (int i = 0; i < num_papers; ++i) {
     PMPaper paper = (PMPaper) [(NSArray* ) paper_list objectAtIndex: i];

[csilv, 2012/09/10 03:27:47]

nit: remove random whitespace making it:
  PMPaper paper = (PMPaper)[(NSArray*)paper_list objectAtIndex: i];

[Vitaly Buka (NO REVIEWS), 2012/09/10 16:44:53]

Done.

-    double paper_width, paper_height;
+    double paper_width = 0.0;
+    double paper_height = 0.0;
     PMPaperGetWidth(paper, &paper_width);
     PMPaperGetHeight(paper, &paper_height);
-    if (default_page_width == paper_width &&
-        default_page_height == paper_height) {
+    double current_match = std::max(fabs(default_page_width - paper_width),
+                                    fabs(default_page_height - paper_height));
+    // Ignore paper that very different.

[csilv, 2012/09/10 03:27:47]

nit: "Ignore paper sizes that are very different."

[Vitaly Buka (NO REVIEWS), 2012/09/10 16:44:53]

Done.

+    if (current_match > 2)
+      continue;
+    current_match += IsPaperNameEqual(paper, default_paper) ? 0 : 1;

[Vitaly Buka (NO REVIEWS), 2012/09/08 01:54:19]

Without line 280 it should work exactly as pre-CL version.

+    if (current_match < best_match) {
       best_matching_paper = paper;
-      break;
-    }
-    // Trying to find the best matching paper.
-    if (fabs(default_page_width - paper_width) < 2 &&
-        fabs(default_page_height - paper_height) < 2) {
-      best_matching_paper = paper;
+      best_match = current_match;
     }
   }
 
   if (best_matching_paper == kPMNoData) {
     PMPaper paper = kPMNoData;
     // Create a custom paper for the specified default page size.
     PMPaperMargins default_margins;
     if (PMPaperGetMargins(default_paper, &default_margins) != noErr)
       return false;
 
@@ skipping 216 matching lines @@
 void PrintingContextMac::ReleaseContext() {
   print_info_.reset();
   context_ = NULL;
 }
 
 gfx::NativeDrawingContext PrintingContextMac::context() const {
   return context_;
 }
 
 }  // namespace printing