Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3552)

Unified Diff: chrome/browser/ui/ash/launcher/launcher_context_menu.cc

Issue 10918103: Give platform apps control over launcher right-click context menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase and fix conflicts Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/launcher/launcher_context_menu.h ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/launcher_context_menu.cc
diff --git a/chrome/browser/ui/ash/launcher/launcher_context_menu.cc b/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
index ca1b3ca08a92df0052c616e1ac7d73b326c15cb6..1df17dfe1578e932d313c23722a8ef54dee550ee 100644
--- a/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
+++ b/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
@@ -7,18 +7,31 @@
#include "ash/launcher/launcher_context_menu.h"
#include "ash/shell.h"
#include "base/command_line.h"
+#include "chrome/browser/extensions/context_menu_matcher.h"
#include "chrome/browser/extensions/extension_prefs.h"
#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
#include "chrome/common/chrome_switches.h"
+#include "content/public/common/context_menu_params.h"
#include "grit/ash_strings.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
+namespace {
+
+bool MenuItemHasLauncherContext(const extensions::MenuItem* item) {
+ return item->contexts().Contains(extensions::MenuItem::LAUNCHER);
+}
+
+} // namespace
+
LauncherContextMenu::LauncherContextMenu(ChromeLauncherController* controller,
const ash::LauncherItem* item)
: ui::SimpleMenuModel(NULL),
controller_(controller),
- item_(item ? *item : ash::LauncherItem()) {
+ item_(item ? *item : ash::LauncherItem()),
+ extension_items_(new extensions::ContextMenuMatcher(
+ controller->profile(), this, this,
+ base::Bind(MenuItemHasLauncherContext))) {
set_delegate(this);
if (is_valid_item()) {
@@ -67,6 +80,14 @@ LauncherContextMenu::LauncherContextMenu(ChromeLauncherController* controller,
}
AddSeparator(ui::NORMAL_SEPARATOR);
}
+ std::string app_id = controller->GetAppIDForLauncherID(item_.id);
+ if (!app_id.empty()) {
+ int index = 0;
+ extension_items_->AppendExtensionItems(
+ app_id, string16(), &index);
+ if (index > 0)
+ AddSeparator(ui::NORMAL_SEPARATOR);
+ }
AddCheckItemWithStringId(
MENU_AUTO_HIDE, ash::LauncherContextMenu::GetAutoHideResourceStringId());
if (CommandLine::ForCurrentProcess()->HasSwitch(
@@ -97,7 +118,7 @@ bool LauncherContextMenu::IsCommandIdChecked(int command_id) const {
case MENU_AUTO_HIDE:
return ash::LauncherContextMenu::IsAutoHideMenuHideChecked();
default:
- return false;
+ return extension_items_->IsCommandIdChecked(command_id);
}
}
@@ -107,7 +128,7 @@ bool LauncherContextMenu::IsCommandIdEnabled(int command_id) const {
return item_.type == ash::TYPE_PLATFORM_APP ||
controller_->IsPinnable(item_.id);
default:
- return true;
+ return extension_items_->IsCommandIdEnabled(command_id);
}
}
@@ -156,5 +177,8 @@ void LauncherContextMenu::ExecuteCommand(int command_id) {
break;
case MENU_ALIGNMENT_MENU:
break;
+ default:
+ extension_items_->ExecuteCommand(command_id,
+ content::ContextMenuParams());
}
}
« no previous file with comments | « chrome/browser/ui/ash/launcher/launcher_context_menu.h ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698