Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 10918102: Make android_webview commits only try the android bot. (Closed)

Created:
8 years, 3 months ago by Torne
Modified:
8 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Make android_webview commits only try the android bot. The logic in PRESUBMIT.py to only try a single OS bot when the changes are for a single OS doesn't work for the android_webview directory because the regex doesn't match at the top level. Tweak the regexes to allow mac/win/android to be the start of the full path. Now, webview code is recognised as being android-specific. R=maruel@chromium.org NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Torne
Hi maruel, we just noticed all the android_webview changes are running a lot of useless ...
8 years, 3 months ago (2012-09-06 17:38:02 UTC) #1
M-A Ruel
Could you list examples where the regexp match or didn't? Got a brain stack overflow.
8 years, 3 months ago (2012-09-06 17:49:58 UTC) #2
Torne
On 2012/09/06 17:49:58, Marc-Antoine Ruel wrote: > Could you list examples where the regexp match ...
8 years, 3 months ago (2012-09-06 18:13:20 UTC) #3
M-A Ruel
On 2012/09/06 18:13:20, Torne wrote: > On 2012/09/06 17:49:58, Marc-Antoine Ruel wrote: > > Could ...
8 years, 3 months ago (2012-09-06 18:15:11 UTC) #4
M-A Ruel
On 2012/09/06 18:15:11, Marc-Antoine Ruel wrote: > lgtm I kindly fixed your description.
8 years, 3 months ago (2012-09-06 18:15:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/10918102/1
8 years, 3 months ago (2012-09-06 18:15:48 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 18:17:00 UTC) #7
Change committed as 155217

Powered by Google App Engine
This is Rietveld 408576698