Issue 10918093: Data for http://codereview.chromium.org/10905117/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10918093: Data for http://codereview.chromium.org/10905117/ (Closed)

Created:
8 years, 3 months ago by mattm

Modified:
8 years, 3 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, arv (Not doing code reviews), oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Data for http://codereview.chromium.org/10905117/ Replace chromium logo from initial version with one based on the official version, and with whitespace cropped. Crop whitespace out of malware image. Add separate image for subresource block interstitial. BUG=143999 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155514

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set			Patch
A	chrome/app/theme/chromium/product_logo_name_48.png	View	1	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/chromium/product_logo_name_96.png	View		+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/safe_browsing/images/2x/malware_icon_v2.png	View	1	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/safe_browsing/images/2x/subresource_icon.png	View	1	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/safe_browsing/images/malware_icon_v2.png	View	1	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/safe_browsing/images/subresource_icon.png	View	1	+-1 lines, --1 lines	0 comments	Download

Total messages: 3 (0 generated)

mattm

files: http://www.corp.google.com/~mattm/no_crawl/chrome/10918093/

8 years, 3 months ago (2012-09-06 01:14:58 UTC) #1

lgtm