Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 10918085: Revert 122501 - Percentage width replaced element in zero percent/fixed width container block incor… (Closed)

Created:
8 years, 6 months ago by Julien - ping for review
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Revert 122501 - Percentage width replaced element in zero percent/fixed width container block incorrectly rendered. https://bugs.webkit.org/show_bug.cgi?id=9493 Patch by Pravin D <pravind.2k4@gmail.com>; on 2012-07-12 Reviewed by Andy Estes. Source/WebCore: When the width of the container is zero percent/fixed value then the width of the replaced element must also be zero. Test: fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html * rendering/RenderBox.cpp: (WebCore::RenderBox::computeReplacedLogicalWidthUsing): When the containing block's available width is zero there can be two cases. The containing block is floated/positioned in which case the width of the replaced child element must be its instrinsic width. On the other hand if the width of the container is specified to be either zero percent or fixed value then the width of the replaced elment must be zero. LayoutTests: * fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html: Added. * fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html: Added. * fast/css/resources/red-box.png: Added. Image resource file for the test case. TBR=commit-queue@webkit.org Committed: https://trac.webkit.org/changeset/127651

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -55 lines) Patch
D LayoutTests/fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/css/resources/red-box.png View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/WebCore/rendering/RenderBox.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Julien - ping for review
8 years, 6 months ago (2012-09-05 22:25:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698