Issue 10918083: Changes to allow testing interface for new NaCl Proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10918083: Changes to allow testing interface for new NaCl Proxy (Closed)

Created:
8 years, 3 months ago by nfullagar

Modified:
8 years, 3 months ago

Reviewers:
dmichael (off chromium), bbudge

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Changes to allow testing interface for new NaCl Proxy BUG=none TEST=ppapi/tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157871

Patch Set 8 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
M	ppapi/ppapi_proxy.gypi	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/proxy/interface_list.cc	View	1 2 3 4 5 6 7	2 chunks	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.cc	View	1 2 3 4 5 6 7	1 chunk	+7 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_testing_proxy.cc	View	1 2 3 4 5 6 7	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bbudge

LGTM http://codereview.chromium.org/10918083/diff/28001/ppapi/proxy/ppb_audio_proxy.cc File ppapi/proxy/ppb_audio_proxy.cc (right): http://codereview.chromium.org/10918083/diff/28001/ppapi/proxy/ppb_audio_proxy.cc#newcode83 ppapi/proxy/ppb_audio_proxy.cc:83: #endif Thanks for the fix. I just noticed ...

8 years, 3 months ago (2012-09-19 22:31:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/10918083/32003

8 years, 3 months ago (2012-09-20 20:53:31 UTC) #5

Change committed as 157871

Expand Messages | Collapse Messages

Issue 10918083: Changes to allow testing interface for new NaCl Proxy (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Messages