adding game_of_life sample

adding game_of_life sample


BUG=

[Siggi Cherem (dart-lang), 2012-09-05 20:53:03]

nice! let's add a layout test too :)

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
File dart/samples/webcomponents/game_of_life/components/components.dart (right):

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/components/components.dart:7: class Cell
extends DivElementImpl implements WebComponent, Hashable {
+dartdoc in classes and importnat methods (e.g. step)

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/components/components.dart:40: static
ComponentConstructorThunk _$constr;
it might be worth to indicate (possibly move to the end of the class) this magic
glue code that is supposed to be autogenerated.

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
File dart/samples/webcomponents/game_of_life/components/components.html (right):

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/components/components.html:12: <element
extends="div" name="x-cell" apply-author-styles>
let's add some documentation for each component, yay :) 

<!-- A component representing a cell in the game of life. This is basically
empty because the DOM portion is trivial, but there is behavior defined in dart
code.... or something better written -->

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/components/components.html:17: <element
extends="div" name="x-control-panel" apply-author-styles>
ditto

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
File dart/samples/webcomponents/game_of_life/game_of_life.dart (right):

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/game_of_life.dart:26: int STEP_TIME =
100;
btw... we'll probably want to be able to set this for benchmarking later on
(e.g. do time = 0) so that we don't hide performance overhead behind this delay.

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/game_of_life.dart:53: class
CellCoordinator {
+dartdoc

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/game_of_life.dart:116:
computedStyles.innerHTML = '${computedStyles.innerHTML}\n$panelStyle';
yikes!
would some other operation work here? nodes.add?

if not, we should at least compute the full string first (e.g. use a string
buffer) and set innerHTML only once at the end? (or even create the styleelement
with the body after we have the contents)

[samhop, 2012-09-07 21:41:30]

ptal

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
File dart/samples/webcomponents/game_of_life/components/components.dart (right):

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/components/components.dart:7: class Cell
extends DivElementImpl implements WebComponent, Hashable {
On 2012/09/05 20:53:03, sigmund wrote:
> +dartdoc in classes and importnat methods (e.g. step)

Done.

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/components/components.dart:40: static
ComponentConstructorThunk _$constr;
On 2012/09/05 20:53:03, sigmund wrote:
> it might be worth to indicate (possibly move to the end of the class) this
magic
> glue code that is supposed to be autogenerated.

Done.

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
File dart/samples/webcomponents/game_of_life/components/components.html (right):

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/components/components.html:12: <element
extends="div" name="x-cell" apply-author-styles>
On 2012/09/05 20:53:03, sigmund wrote:
> let's add some documentation for each component, yay :) 
> 
> <!-- A component representing a cell in the game of life. This is basically
> empty because the DOM portion is trivial, but there is behavior defined in
dart
> code.... or something better written -->

Done.

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/components/components.html:17: <element
extends="div" name="x-control-panel" apply-author-styles>
On 2012/09/05 20:53:03, sigmund wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
File dart/samples/webcomponents/game_of_life/game_of_life.dart (right):

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/game_of_life.dart:26: int STEP_TIME =
100;
On 2012/09/05 20:53:03, sigmund wrote:
> btw... we'll probably want to be able to set this for benchmarking later on
> (e.g. do time = 0) so that we don't hide performance overhead behind this
delay.

Done.

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/game_of_life.dart:53: class
CellCoordinator {
On 2012/09/05 20:53:03, sigmund wrote:
> +dartdoc

Done.

https://chromiumcodereview.appspot.com/10918082/diff/1/dart/samples/webcompon...
dart/samples/webcomponents/game_of_life/game_of_life.dart:116:
computedStyles.innerHTML = '${computedStyles.innerHTML}\n$panelStyle';
On 2012/09/05 20:53:03, sigmund wrote:
> yikes!
> would some other operation work here? nodes.add?
> 
> if not, we should at least compute the full string first (e.g. use a string
> buffer) and set innerHTML only once at the end? (or even create the
styleelement
> with the body after we have the contents)

Done.

[Siggi Cherem (dart-lang), 2012-09-07 22:04:09]

very nice! lgtm!

https://chromiumcodereview.appspot.com/10918082/diff/8001/dart/samples/webcom...
File dart/samples/webcomponents/game_of_life/components/components.dart (right):

https://chromiumcodereview.appspot.com/10918082/diff/8001/dart/samples/webcom...
dart/samples/webcomponents/game_of_life/components/components.dart:11: typedef
void Ping();
Pong? this might need some explanation.

[samhop, 2012-09-07 23:55:17]

https://chromiumcodereview.appspot.com/10918082/diff/8001/dart/samples/webcom...
File dart/samples/webcomponents/game_of_life/components/components.dart (right):

https://chromiumcodereview.appspot.com/10918082/diff/8001/dart/samples/webcom...
dart/samples/webcomponents/game_of_life/components/components.dart:11: typedef
void Ping();
On 2012/09/07 22:04:09, sigmund wrote:
> Pong? this might need some explanation.

Done.