Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Issue 10918076: Make webkit_compositor_support depend directly on WebKit.gyp:webkit (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Make webkit_compositor_support depend directly on WebKit.gyp:webkit This is necessary to pick up a direct_dependent_settings in the chromium_code=0 case (i.e. a WebKit checkout with chromium deps) so includes of the form: #include "third_party/WebKit/..." work as expected BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154974

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webkit/compositor_bindings/compositor_bindings.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Beverloo
LGTM, but you'll need owners too (though a TBR should be fine). You seem to ...
8 years, 3 months ago (2012-09-05 16:34:00 UTC) #1
jamesr
On 2012/09/05 16:34:00, Peter Beverloo wrote: > LGTM, but you'll need owners too (though a ...
8 years, 3 months ago (2012-09-05 16:46:08 UTC) #2
jamesr
8 years, 3 months ago (2012-09-05 16:48:01 UTC) #3
Will land soon as mac/win come back - they look good so far but I've been bitten
by really weird component issues a lot lately so I want to be sure before
inflicting this upon everyone.

Powered by Google App Engine
This is Rietveld 408576698