Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: rietveld.py

Issue 10918075: Change Rietveld.add_comment() to not add the user as a reviewer by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index 88f024b6ca05309c26dc6ae30420134d8f4ebba9..94f7c6f524ce3212e02d7496960a242a61af1563 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -226,7 +226,7 @@ class Rietveld(object):
('description', description),
('xsrf_token', self.xsrf_token())])
- def add_comment(self, issue, message):
+ def add_comment(self, issue, message, add_as_reviewer=False):
max_message = 10000
tail = '…\n(message too large)'
if len(message) > max_message:
@@ -236,6 +236,7 @@ class Rietveld(object):
('xsrf_token', self.xsrf_token()),
('message', message),
('message_only', 'True'),
+ ('add_as_reviewer', str(bool(add_as_reviewer))),
('send_mail', 'True'),
('no_redirect', 'True')])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698