Check the return value of API calls on ia32 and x64.

Check the return value of API calls on ia32 and x64.

This implies that the return value of native getters is checked. The nice part
is that one can even see the name of the property in question in the abort
output when the check failed.

Under some circumstances even the return value of interceptors gets checked, but
I'm not 100% sure about this, because the interceptor code is basically tuned to
death.

The change seems to have very low overhead, so it might be feasible to keep this
check enabled unconditionally.

Committed: https://code.google.com/p/v8/source/detail?r=12446

[Jakob Kummerow, 2012-09-05 14:08:51]

patch set 3 LGTM.

http://codereview.chromium.org/10918071/diff/1/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/10918071/diff/1/src/ia32/macro-assembler-ia32....
src/ia32/macro-assembler-ia32.cc:1961: cmp(return_value,
isolate()->factory()->undefined_value());
I guess you don't want to do a CmpInstanceType(map, ODDBALL_TYPE) because you
want to exclude the hole from valid values, right?

http://codereview.chromium.org/10918071/diff/2002/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/10918071/diff/2002/src/objects.cc#newcode214
src/objects.cc:214: #if 1
#if ENABLE_EXTRA_CHECKS maybe?

[Sven Panne, 2012-09-05 14:11:47]

Landing...

http://codereview.chromium.org/10918071/diff/1/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/10918071/diff/1/src/ia32/macro-assembler-ia32....
src/ia32/macro-assembler-ia32.cc:1961: cmp(return_value,
isolate()->factory()->undefined_value());
On 2012/09/05 14:08:51, Jakob wrote:
> I guess you don't want to do a CmpInstanceType(map, ODDBALL_TYPE) because you
> want to exclude the hole from valid values, right?

Yes, and things are stricter this way, because somebody could construct an odd
Oddball. :-)

http://codereview.chromium.org/10918071/diff/2002/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/10918071/diff/2002/src/objects.cc#newcode214
src/objects.cc:214: #if 1
On 2012/09/05 14:08:51, Jakob wrote:
> #if ENABLE_EXTRA_CHECKS maybe?

Done.