chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc - Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove the auxiliary structure for non-URL cases. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/favicon_source.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc b/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

index 05d8d35298bb7a479b8840bc52980b36dac5546b..8c9b3ea5abc2a33cd491ae845f28e2b04bfcf555 100644

--- a/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

+++ b/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

@@ -355,12 +355,13 @@ void BookmarksHandler::HandleCreateHomeScreenBookmarkShortcut(

FaviconService* favicon_service = FaviconServiceFactory::GetForProfile(

profile, Profile::EXPLICIT_ACCESS);

FaviconService::Handle handle = favicon_service->GetRawFaviconForURL(

- profile,

- node->url(),

- history::FAVICON | history::TOUCH_ICON,

- gfx::kFaviconSize,

+ FaviconService::FaviconForURLParams(

+ profile,

+ node->url(),

+ history::FAVICON | history::TOUCH_ICON,

+ gfx::kFaviconSize,

+ &cancelable_consumer_),

ui::SCALE_FACTOR_100P,

- &cancelable_consumer_,

base::Bind(&BookmarksHandler::OnShortcutFaviconDataAvailable,

base::Unretained(this)));

cancelable_consumer_.SetClientData(favicon_service, handle, node);