chrome/browser/ui/cocoa/history_menu_bridge.mm - Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/history_menu_bridge.mm

Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove the auxiliary structure for non-URL cases. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/session_model_associator.cc ('k') | chrome/browser/ui/intents/web_intent_picker_controller.cc » ('j') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/history_menu_bridge.mm

diff --git a/chrome/browser/ui/cocoa/history_menu_bridge.mm b/chrome/browser/ui/cocoa/history_menu_bridge.mm

index 2f73278b66b652b8b5bca6a399cfcf3a30845c94..2aa9644da635989cda8da4eb1880adebda4413a0 100644

--- a/chrome/browser/ui/cocoa/history_menu_bridge.mm

+++ b/chrome/browser/ui/cocoa/history_menu_bridge.mm

@@ -456,8 +456,8 @@ void HistoryMenuBridge::GetFaviconForHistoryItem(HistoryItem* item) {

FaviconService* service =

FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);

FaviconService::Handle handle = service->GetFaviconImageForURL(

- profile_, item->url, history::FAVICON, gfx::kFaviconSize,

- &favicon_consumer_,

+ FaviconService::FaviconForURLParams(profile_, item->url, history::FAVICON,

+ gfx::kFaviconSize, &favicon_consumer_),

base::Bind(&HistoryMenuBridge::GotFaviconData, base::Unretained(this)));

favicon_consumer_.SetClientData(service, handle, item);

item->icon_handle = handle;