Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: chrome/browser/jumplist_win.cc

Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove the auxiliary structure for non-URL cases. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/jumplist_win.cc
diff --git a/chrome/browser/jumplist_win.cc b/chrome/browser/jumplist_win.cc
index 5e36a6af10f1da5783bf660af80eb9ad3a860eb8..afdf7e74dabf44425fc16832931660efbd95de4a 100644
--- a/chrome/browser/jumplist_win.cc
+++ b/chrome/browser/jumplist_win.cc
@@ -709,7 +709,8 @@ void JumpList::StartLoadingFavicon() {
FaviconService* favicon_service =
FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
handle_ = favicon_service->GetFaviconImageForURL(
- profile_, url, history::FAVICON, gfx::kFaviconSize, &favicon_consumer_,
+ FaviconService::FaviconForURLParams(profile_, url, history::FAVICON,
+ gfx::kFaviconSize, &favicon_consumer_),
base::Bind(&JumpList::OnFaviconDataAvailable, base::Unretained(this)));
}

Powered by Google App Engine
This is Rietveld 408576698