chrome/browser/favicon/favicon_handler.cc - Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler.cc

Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove the auxiliary structure for non-URL cases. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bookmarks/bookmark_model.cc ('k') | chrome/browser/favicon/favicon_service.h » ('j') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/favicon/favicon_handler.cc

diff --git a/chrome/browser/favicon/favicon_handler.cc b/chrome/browser/favicon/favicon_handler.cc

index 6152d642145e580a1fc9333da8959a2586493e0c..93e6089e0cc97358a5a4b6b052a85786e4f6e3ea 100644

--- a/chrome/browser/favicon/favicon_handler.cc

+++ b/chrome/browser/favicon/favicon_handler.cc

@@ -393,9 +393,10 @@ void FaviconHandler::GetFaviconForURL(

int icon_types,

CancelableRequestConsumerBase* consumer,

const FaviconService::FaviconResultsCallback& callback) {

- GetFaviconService()->GetFaviconForURL(profile_, page_url, icon_types,

- preferred_icon_size(), ui::GetSupportedScaleFactors(), consumer,

- callback);

+ GetFaviconService()->GetFaviconForURL(

+ FaviconService::FaviconForURLParams(profile_, page_url, icon_types,

+ preferred_icon_size(), consumer),

+ ui::GetSupportedScaleFactors(), callback);

}

void FaviconHandler::SetHistoryFavicon(