Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/bookmarks/bookmark_html_writer.cc

Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove the auxiliary structure for non-URL cases. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_html_writer.cc
diff --git a/chrome/browser/bookmarks/bookmark_html_writer.cc b/chrome/browser/bookmarks/bookmark_html_writer.cc
index 501bed3e1fad960871604bbd354e630fb919424a..6e2412d24964e5b50e0aa077aaf1b24171783888 100644
--- a/chrome/browser/bookmarks/bookmark_html_writer.cc
+++ b/chrome/browser/bookmarks/bookmark_html_writer.cc
@@ -461,9 +461,10 @@ bool BookmarkFaviconFetcher::FetchNextFavicon() {
if (favicons_map_->end() == iter) {
FaviconService* favicon_service = FaviconServiceFactory::GetForProfile(
profile_, Profile::EXPLICIT_ACCESS);
- favicon_service->GetRawFaviconForURL(profile_, GURL(url),
- history::FAVICON, gfx::kFaviconSize, ui::SCALE_FACTOR_100P,
- &favicon_consumer_,
+ favicon_service->GetRawFaviconForURL(
+ FaviconService::FaviconForURLParams(profile_, GURL(url),
+ history::FAVICON, gfx::kFaviconSize, &favicon_consumer_),
+ ui::SCALE_FACTOR_100P,
base::Bind(&BookmarkFaviconFetcher::OnFaviconDataAvailable,
base::Unretained(this)));
return true;
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model.cc » ('j') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698