Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 10918058: Fix PDF Viewer control loading at HiDPI scale factors (Closed)

Created:
8 years, 3 months ago by Josh Horwich
Modified:
8 years, 3 months ago
Reviewers:
brettw, oshima
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fix PDF Viewer control loading at HiDPI scale factors Fix PDF Viewer's controls at high DPI - the implementation of PPB_PDF was checking to see if the representation was already loaded, which would fail as of http://codereview.chromium.org/10820049/ since we now load 2x resources on-demand. Now we just check the resulting image for correctness instead. BUG=146109 TEST=Manual, run PDF Viewer on Retina display, mouse over controls to note size Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/renderer/pepper/ppb_pdf_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Josh Horwich
Please take a look oshima for familiarity with resource loading changes brettw for OWNERS
8 years, 3 months ago (2012-09-04 18:15:29 UTC) #1
brettw
LGTM rubberstamp, I didn't think about the logic.
8 years, 3 months ago (2012-09-04 20:08:30 UTC) #2
oshima
lgtm
8 years, 3 months ago (2012-09-04 20:17:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhorwich@chromium.org/10918058/1
8 years, 3 months ago (2012-09-04 20:18:18 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-04 22:39:37 UTC) #5
Change committed as 154829

Powered by Google App Engine
This is Rietveld 408576698