Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/renderer/extensions/native_handler.h

Issue 10918042: Use MakeWeak() to clean up function pointers in NativeHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: respond to comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/module_system.cc ('k') | chrome/renderer/extensions/native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/native_handler.h
diff --git a/chrome/renderer/extensions/native_handler.h b/chrome/renderer/extensions/native_handler.h
index f9eb4fe0e40ccfc3bb52812f0db65d7f9726d5e1..1de13ba6ea35b02af11bd1b20d5b7e55b37e510c 100644
--- a/chrome/renderer/extensions/native_handler.h
+++ b/chrome/renderer/extensions/native_handler.h
@@ -6,11 +6,9 @@
#define CHROME_RENDERER_EXTENSIONS_NATIVE_HANDLER_H_
#include "base/bind.h"
-#include "base/memory/linked_ptr.h"
#include "v8/include/v8.h"
#include <string>
-#include <vector>
namespace extensions {
@@ -48,8 +46,9 @@ class NativeHandler {
private:
static v8::Handle<v8::Value> Router(const v8::Arguments& args);
+ static void DisposeFunction(v8::Persistent<v8::Value> object,
+ void* parameter);
- std::vector<linked_ptr<HandlerFunction> > handler_functions_;
v8::Persistent<v8::ObjectTemplate> object_template_;
DISALLOW_COPY_AND_ASSIGN(NativeHandler);
« no previous file with comments | « chrome/renderer/extensions/module_system.cc ('k') | chrome/renderer/extensions/native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698