Issue 10918024: Revert 154294 - Remove DownloadFileManager in favor of direct ownership of DownloadFiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10918024: Revert 154294 - Remove DownloadFileManager in favor of direct ownership of DownloadFiles. (Closed)

Created:
8 years, 3 months ago by Randy Smith (Not in Mondays)

Modified:
8 years, 3 months ago

Reviewers:
Randy Smith (Not in Mondays)

CC:
chromium-reviews, dyu1, Nirnimesh, jam, joi+watch-content_chromium.org, rginda+watch_chromium.org, anantha, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 154294 - Remove DownloadFileManager in favor of direct ownership of DownloadFiles. This CL is equivalent to CLs * http://codereview.chromium.org/10799005, * http://codereview.chromium.org/10836293, * https://chromiumcodereview.appspot.com/10823406, and * http://codereview.chromium.org/10867065 which were previous attempts to land the same functionality. R=benjhayden@chromium.org TBR=jam@chromium.org BUG=123998 BUG=144751 Review URL: https://chromiumcodereview.appspot.com/10900010 TBR=rdsmith@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154445

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+904 lines, -1276 lines)			Patch
M	chrome/browser/download/download_browsertest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/download/save_page_browsertest.cc	View	16 chunks	+29 lines, -139 lines	0 comments	Download
M	chrome/test/functional/downloads.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/browser_context.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	content/browser/download/base_file.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/download/base_file.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/download/download_file.h	View	4 chunks	+11 lines, -13 lines	0 comments	Download
D	content/browser/download/download_file_factory.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	content/browser/download/download_file_factory.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	content/browser/download/download_file_impl.h	View	5 chunks	+25 lines, -22 lines	0 comments	Download
M	content/browser/download/download_file_impl.cc	View	8 chunks	+64 lines, -65 lines	0 comments	Download
A +	content/browser/download/download_file_manager.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/browser/download/download_file_manager.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/browser/download/download_file_manager_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	content/browser/download/download_file_unittest.cc	View	16 chunks	+83 lines, -66 lines	0 comments	Download
M	content/browser/download/download_item_impl.h	View	9 chunks	+16 lines, -45 lines	0 comments	Download
M	content/browser/download/download_item_impl.cc	View	19 chunks	+45 lines, -200 lines	0 comments	Download
M	content/browser/download/download_item_impl_delegate.h	View	1 chunk	+2 lines, -12 lines	0 comments	Download
M	content/browser/download/download_item_impl_delegate.cc	View	2 chunks	+4 lines, -9 lines	0 comments	Download
M	content/browser/download/download_item_impl_unittest.cc	View	22 chunks	+78 lines, -165 lines	0 comments	Download
M	content/browser/download/download_manager_impl.h	View	10 chunks	+28 lines, -25 lines	0 comments	Download
M	content/browser/download/download_manager_impl.cc	View	22 chunks	+173 lines, -62 lines	0 comments	Download
M	content/browser/download/download_manager_impl_unittest.cc	View	19 chunks	+82 lines, -100 lines	0 comments	Download
M	content/browser/download/download_resource_handler.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/download/mock_download_file.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/download/mock_download_file.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	content/browser/download/save_package.cc	View	8 chunks	+15 lines, -46 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_impl.h	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_impl.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/content_browser.gypi	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	content/public/browser/download_destination_observer.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	content/public/browser/download_manager.h	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	content/public/test/mock_download_manager.h	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	content/public/test/test_file_error_injector.h	View	6 chunks	+16 lines, -18 lines	0 comments	Download
M	content/public/test/test_file_error_injector.cc	View	13 chunks	+169 lines, -151 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages